Fix the detection of an unhappy installation path in a venv under Windows#554
Open
Fix the detection of an unhappy installation path in a venv under Windows#554
Conversation
tramora
force-pushed
the
548-fix-status-pip-on-windows
branch
from
1029be1 to
92b1a47
Compare
popescu-v
reviewed
Feb 17, 2026
popescu-v
reviewed
Feb 17, 2026
- External tools like VSCode can modify for example the case of the path saved in `sys.executable` - As a general rule paths under Windows are case-insensitive
tramora
force-pushed
the
548-fix-status-pip-on-windows
branch
from
92b1a47 to
3606064
Compare
popescu-v
reviewed
Feb 18, 2026
| library_root_dir = str(library_root_dir_path) | ||
| if platform.system() == "Windows": | ||
| # warning : paths are case-insensitive under Windows | ||
| library_root_dir = library_root_dir.lower() |
Collaborator
There was a problem hiding this comment.
I would .lower() the user_site_packages_dir variable on Windows as well, to observe the case-insesitiveness invariant on Windows.
popescu-v
requested changes
Feb 18, 2026
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
See the remaining open comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External tools like VSCode can modify the case of the path saved in
sys.executableFixes #548
The case is indeed reproductible in saving the value of
sys.executableand altering its case.Implementing an automatic test would required extracting a function returning
sys.executableand mocking it during the test.Possible but but a bit overkill.
TODO Before Asking for a Review
main(ormain-v10)Unreleasedsection ofCHANGELOG.md(no date)index.html